-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIMS-1537: Add more options to reprocessing #876
base: master
Are you sure you want to change the base?
LIMS-1537: Add more options to reprocessing #876
Conversation
When going to
Does this also happen on your end? This does not happen on |
Doesn't happen for me. I assume from the error it is something to do with #853 but not sure why it would appear... EDIT: Have fixed the merge conflict, which brings in master, so maybe that'll help? |
That solved it, but now there's a slightly more annoying issue, pressing "integrate" does nothing, the backend basically ignores the body of Seems like the body is "discarded" between line 505 and 640 of |
Yeah I'm getting that too. Will have a think. |
Ok, found some old Slack chats with John, for me this is caused by some weird cookie or cache thing in the browser. I've cleared my cookies and now it runs, see /dc/visit/mx23694-125/id/16200751. Not sure why that doesn't work for you though... |
It's really odd, sometimes clearing data/cookies works for me, other times it doesn't... I'm going to keep trying, maybe sometime it'll fix itself |
Good spot, hopefully fixed in last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in dev-6
, all seems good!
JIRA ticket: LIMS-1537
Summary:
Add the d_max option and the absorption level option (for xia2 only) for reprocessing jobs. Also fix a bug in space groups when 'process individually' is ticked.
Changes:
To test: